Add scheduleToStart timeout to Local Activities#1560
Merged
Spikhalskiy merged 1 commit intotemporalio:masterfrom Dec 9, 2022
Merged
Add scheduleToStart timeout to Local Activities#1560Spikhalskiy merged 1 commit intotemporalio:masterfrom
Spikhalskiy merged 1 commit intotemporalio:masterfrom
Conversation
75a342d to
a80f27c
Compare
b4366e2 to
0b8b6ff
Compare
Sushisource
approved these changes
Dec 9, 2022
Member
Sushisource
left a comment
There was a problem hiding this comment.
Looks good to me. This definitely improved the readability in the worker a bit
Comment on lines
+287
to
+288
| // TODO do we have to fail? if we didn't fit in a potentially tight timeout left until | ||
| // wftHeartbeatDeadline, |
Member
There was a problem hiding this comment.
I don't think you do. In core there is no bound on the local activity queue, just the number of slots.
Contributor
Author
There was a problem hiding this comment.
Yeah, it's not really a question, it's just a representation of my thinking. I think we should limit it by one WFT timeout though and fail WFT after to get backpressure all the way up. May be especially important if one worker experiences issues that cause long LA execution and exhausting of LA executor threads.
I will think more about how to improve it. This preserves the existing behavior for now in this regard.
162a0f0 to
76895da
Compare
…, add more retry guard clauses Issue temporalio#1512
76895da to
ab2de95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalActivityWorker is reworked to remove the unneeded poller and two queues between the workflow code and the executor have been reduced to one.
Backpressure for new executions is implemented with retries always having a green light.
Additional guards were added that prevent retries when activity execution is already completed by a timeout.
Partially addresses #1510
Closes #1512