Skip to content

Local Activities fail and don't retry after reaching LocalRetryThreshold #1261

@Spikhalskiy

Description

@Spikhalskiy

Expected Behavior

Local Activity should schedule a timer on the server when it reaches LocalActivityThreshold according to its backoff strategy.

Actual Behavior

Instead, if Local Activity fails after LocalActivityThreshold is reached, the fail propagates to the workflow

Steps to Reproduce the Problem

Unit test Spikhalskiy@ea6252a#diff-b74049b45234315b43ae6729f80ee4c54cca4cbb081f97ef9ab42cc77e9e3264R39 is expected to pass, but instead, it fails.

Additional context

It looks like the code that was scheduling the timer was removed by mistake in the PR from the earliest days of Temporal that was reimplementing errors handling, specifically here: https://github.com/temporalio/sdk-java/pull/101/files#diff-f6a342e5baa618f03fdb6a83c6e070e5b57b9a9d9f3e1460b928149faa12b57cR237

It wasn't caught because the unit test testing La backoff that falls back to the server timers is not tested by the existing tests.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions