Extend test helpers by stephanos · Pull Request #189 · temporalio/omes

stephanos · 2025-08-18T18:01:05Z

What was changed

Prelude for #179:

adds partial history matching (when full matching won't work)
scopes build logs to test run
runs kitchen sink tests in parallel
fixes data race
adds new end-to-end ThroughputStress test

Why?

Improve test experience.

Checklist

Closes
How was this tested:

Any docs updates needed?

stephanos · 2025-08-18T18:01:29Z

      - name: Test Kitchensink ${{ matrix.sdk }}
        run: |
-          SDK=${{ matrix.sdk }} go test -race ./loadgen -run TestKitchensink -v
+          SDK=${{ matrix.sdk }} go test -race ./loadgen -run TestKitchenSink -v


Renamed for consistency.

stephanos · 2025-08-18T18:01:52Z

+//	WorkflowExecutionStarted {"taskQueue":"foo-bar"}
+//	...
+//	WorkflowExecutionCompleted
+type partialHistoryMatcher string


Needed because some tests are not deterministic enough to run the full history matcher.

stephanos · 2025-08-18T18:02:11Z

 	if executeErr != nil {
 		return fmt.Errorf("failed to execute kitchen sink workflow: %w", executeErr)
 	}
-	if clientActionsErr != nil {


Data race here.

stephanos · 2025-08-18T18:02:47Z

+	if b.stdout == nil {
+		b.stdout = &logWriter{logger: b.Logger}
+	}
+	if b.stderr == nil {


With these the build logs will be associated with the right test logs.

stephanos · 2025-08-18T18:07:24Z

@@ -0,0 +1,190 @@
+package kitchensink


Moved over here for discoverability (helpful once we have multiple impls).

stephanos · 2025-08-18T18:08:03Z

-	EventID int64
-	Type    string
-	Fields  map[string]any
+type event struct {


Some refactorings to make the events a typed entity.

stephanos · 2025-08-18T18:08:35Z

 		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()


stephanos · 2025-08-18T18:11:01Z

 	github.com/spf13/pflag v1.0.5
 	github.com/stretchr/testify v1.10.0
-	github.com/temporalio/features v0.0.0-20250714172315-c9d352c46b16
+	github.com/temporalio/features v0.0.0-20250808182149-bb2a99cdf200


Updated to pull in temporalio/features#662

stephanos · 2025-08-18T18:46:17Z

+	"github.com/temporalio/omes/loadgen"
+)
+
+func TestThroughputStress(t *testing.T) {


New end-to-end test using the new test environment.

stephanos · 2025-08-18T18:59:20Z

+				WorkflowExecutionCompleted`),
+		},
+		{
+			name: "ClientSequence - Nested",


Example of a new test case that uses partialHistoryMatcher - more to follow.

stephanos · 2025-08-18T19:00:05Z

-	return historyEvents
-}
-
-func ensureWorkerBuilt(t *testing.T, sdk cmdoptions.Language) error {


Moved all this into test helper.

stephanos · 2025-08-18T19:08:09Z

 	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/stretchr/objx v0.5.2 // indirect
 	github.com/stretchr/testify v1.10.0 // indirect
+	github.com/temporalio/features v0.0.0-20250808182149-bb2a99cdf200 // indirect


Transitive dependency ...

Sushisource

I guess a bunch of this is in the Go Client activity type PR, yes? Just skimmed it b/c of that.

stephanos · 2025-08-27T16:54:51Z

Oh yeah, it's the same commit as in #179

ℹ️ This PR includes the #189 PR; you can just look at the "Client ActivityType" commit for review.    ## What was changed  Adds new "Client" ActivityType to execute client actions (e.g. Update, Signal) from a workflow activity. ## Why?  - Keeps all action execution in one place (ie the workflow). - Makes client actions part of the event history (free resume-ability, easier debugging). - Execution is (more) deterministic. ## Checklist  1. Closes  2. How was this tested:  3. Any docs updates needed?