Skip to content

Conversation

@xHeaven
Copy link
Contributor

@xHeaven xHeaven commented Feb 10, 2026

Fixes #182.

@coveralls
Copy link

coveralls commented Feb 10, 2026

Pull Request Test Coverage Report for Build 21870777515

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.234%

Totals Coverage Status
Change from base Build 21870697880: 0.0%
Covered Lines: 1557
Relevant Lines: 1670

💛 - Coveralls

@xHeaven xHeaven force-pushed the fix/twig-deletion-injection-conflict branch from 0c59e97 to 6189306 Compare February 10, 2026 13:07
@xHeaven
Copy link
Contributor Author

xHeaven commented Feb 10, 2026

Let's merge #190 first so the benchmark can run in this one.

@xHeaven xHeaven force-pushed the fix/twig-deletion-injection-conflict branch from 6189306 to c0bc625 Compare February 10, 2026 13:39
@xHeaven xHeaven force-pushed the fix/twig-deletion-injection-conflict branch from c0bc625 to 8a3e03c Compare February 10, 2026 15:19
@github-actions
Copy link

Benchmark Results

Comparison of fix/twig-deletion-injection-conflict against main (504ca74c57861b0058747c4c7db46dc25838a5a3).

Storing results ... OK
Run: 135257205dd6ffc242471d48efceee10e69aa862
+------------------+------------+------------+------+-----+-----------------+-----------------------+-----------------+
| benchmark        | subject    | set        | revs | its | mem_peak        | mode                  | rstdev          |
+------------------+------------+------------+------+-----+-----------------+-----------------------+-----------------+
| HighlighterBench | benchParse | blade      | 100  | 5   | 2.582mb +0.02%  | 926.039119μs -0.88%   | ±0.84% +58.96%  |
| HighlighterBench | benchParse | css        | 100  | 5   | 2.032mb 0.00%   | 136.325519μs +0.05%   | ±0.83% +14.28%  |
| HighlighterBench | benchParse | diff       | 100  | 5   | 2.032mb 0.00%   | 25.877260μs -0.82%    | ±0.87% -14.01%  |
| HighlighterBench | benchParse | dockerfile | 100  | 5   | 2.031mb 0.00%   | 78.922642μs -0.14%    | ±0.42% +17.08%  |
| HighlighterBench | benchParse | dotenv     | 100  | 5   | 2.031mb 0.00%   | 75.499569μs +0.18%    | ±0.33% +4.80%   |
| HighlighterBench | benchParse | ellison    | 100  | 5   | 2.090mb +0.02%  | 313.128943μs +0.87%   | ±0.55% -33.46%  |
| HighlighterBench | benchParse | gdscript   | 100  | 5   | 2.084mb +0.02%  | 317.517534μs +0.09%   | ±0.64% +29.65%  |
| HighlighterBench | benchParse | html       | 100  | 5   | 2.031mb 0.00%   | 108.164286μs +0.78%   | ±0.92% +401.54% |
| HighlighterBench | benchParse | ini        | 100  | 5   | 2.030mb 0.00%   | 84.815695μs -0.49%    | ±0.29% -49.25%  |
| HighlighterBench | benchParse | javascript | 100  | 5   | 2.071mb +0.02%  | 259.323992μs -0.25%   | ±0.38% +89.41%  |
| HighlighterBench | benchParse | json       | 100  | 5   | 2.047mb +0.02%  | 232.716047μs +0.81%   | ±0.61% +33.72%  |
| HighlighterBench | benchParse | markdown   | 100  | 5   | 2.032mb 0.00%   | 72.209452μs +0.26%    | ±0.60% -39.55%  |
| HighlighterBench | benchParse | php        | 100  | 5   | 2.350mb +0.02%  | 710.377926μs +0.14%   | ±0.55% +8.82%   |
| HighlighterBench | benchParse | python     | 100  | 5   | 2.247mb +0.02%  | 406.045284μs -0.20%   | ±0.29% -52.76%  |
| HighlighterBench | benchParse | sql        | 100  | 5   | 2.030mb 0.00%   | 150.562466μs +0.15%   | ±0.72% +117.70% |
| HighlighterBench | benchParse | twig       | 100  | 5   | 19.118mb +0.00% | 1,309.404364μs -0.95% | ±0.27% -41.87%  |
| HighlighterBench | benchParse | xml        | 100  | 5   | 2.037mb 0.00%   | 175.479785μs +0.16%   | ±0.30% -14.04%  |
| HighlighterBench | benchParse | yaml       | 100  | 5   | 2.080mb +0.02%  | 312.773679μs -0.42%   | ±0.38% +8.01%   |
+------------------+------------+------------+------+-----+-----------------+-----------------------+-----------------+

Generated by phpbench against commit 8a3e03c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflict between Twig language and DeletionInjection

2 participants