Skip to content

Fix lighthouse-ci-action input name for run count#106

Merged
tehw0lf merged 1 commit into
mainfrom
fix/lighthouse-runs-input-name
Jul 13, 2026
Merged

Fix lighthouse-ci-action input name for run count#106
tehw0lf merged 1 commit into
mainfrom
fix/lighthouse-runs-input-name

Conversation

@tehw0lf

@tehw0lf tehw0lf commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fixes Use multi-run median for lighthouse performance score #105: numberOfRuns is not a valid input for treosh/lighthouse-ci-action — the correct input is runs. CI failed with "Unexpected input(s) 'numberOfRuns'".
  • actionlint doesn't validate third-party action input schemas (only reusable workflow inputs/outputs/secrets), so this slipped through the lint gate on the previous PR.

Test plan

  • actionlint .github/workflows/lighthouse-scan.yml passes (as before — doesn't catch this class of error)
  • Re-run the weekly lighthouse scan workflow in a consumer repo and confirm it no longer errors on unexpected input

https://claude.ai/code/session_01YXxxzAa9Mk67SjBqHwrmqm

Summary by CodeRabbit

  • Chores
    • Updated Lighthouse CI scan configuration to use the supported run-count setting.
    • Existing scan logic and reporting remain unchanged.

treosh/lighthouse-ci-action expects 'runs', not 'numberOfRuns' -
the previous PR (#105) used a non-existent input name, which the
action rejected at runtime ("Unexpected input(s) 'numberOfRuns'").
actionlint doesn't validate third-party action input schemas, so
this wasn't caught before merge.

Claude-Session: https://claude.ai/code/session_01YXxxzAa9Mk67SjBqHwrmqm
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 487021f2-5103-4b88-b843-2fe9a19ab16f

📥 Commits

Reviewing files that changed from the base of the PR and between dc8df35 and 0149554.

📒 Files selected for processing (1)
  • .github/workflows/lighthouse-scan.yml

📝 Walkthrough

Walkthrough

The Lighthouse CI workflow changes its run-count action input from numberOfRuns to runs, while continuing to source the value from inputs.num_runs.

Changes

Lighthouse workflow configuration

Layer / File(s) Summary
Update Lighthouse run count input
.github/workflows/lighthouse-scan.yml
The Lighthouse CI action now receives inputs.num_runs through the runs input.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: dependabot[bot]

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the workflow fix by renaming the Lighthouse CI action input used for run count.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lighthouse-runs-input-name

Comment @coderabbitai help to get the list of available commands.

@tehw0lf tehw0lf merged commit 7ef1a07 into main Jul 13, 2026
2 of 3 checks passed
@tehw0lf tehw0lf deleted the fix/lighthouse-runs-input-name branch July 13, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant