Skip to content

Updated statistics in FRC section#141

Merged
EkVasilyeva merged 6 commits into
team178:masterfrom
178Laptop:master
Apr 29, 2020
Merged

Updated statistics in FRC section#141
EkVasilyeva merged 6 commits into
team178:masterfrom
178Laptop:master

Conversation

@178Laptop

@178Laptop 178Laptop commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

moved the FRC specific statistics to the FRC section, going to add more about other FIRST programs in the FIRST section to replace

(For #139)

moved the FRC specific statistics to the FRC section, going to add more about other FIRST programs in the FIRST section to replace
@TJScalzo TJScalzo changed the title Updated statistics in FRC section #139 Updated statistics in FRC section Feb 6, 2020

@TJScalzo TJScalzo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left detailed comments on specific parts of the file. But my main suggestion is to go through and redistribute details between the paragraphs after rearranging them slightly. The first paragraph would have general details about what FRC is. The second would have more detailed info about procedure and how the game works. The third builds off the second one and focuses on the current season. And the last one is all the new fun facts.

Please try to test the page locally before pushing your changes. There were some formatting issues that would have been caught if these changes were tested beforehand.

(Also, I moved the issue number out of the title of the pull request. While that may work in commit messages, you need to put it in the comment of the pull request for it to link properly.)

Comment thread first/frc/index.md Outdated
Comment thread first/frc/index.md Outdated
Comment thread first/frc/index.md Outdated
Comment thread first/frc/index.md Outdated
Comment thread first/frc/index.md Outdated
Comment thread first/frc/index.md Outdated
Comment thread first/frc/index.md Outdated
@TJScalzo TJScalzo linked an issue Feb 7, 2020 that may be closed by this pull request
5 tasks
TJScalzo and others added 2 commits April 26, 2020 19:59
Making it easier to use in other places like the FRC page
Me and @TJScalzo worked on editing the pull request #141, rewrote and re-organized the paragraphs, made section about this year's games prettier, and made all changes according to Tim's comments (thank you :) )
TJScalzo added a commit that referenced this pull request Apr 29, 2020
@EkVasilyeva
EkVasilyeva merged commit c889321 into team178:master Apr 29, 2020
TJScalzo added a commit that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants