Normative: Align async modules rejection order with fulfillment order #3695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rendered spec for this PR is available at https://tc39.es/ecma262/pr/3695. |
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Oct 3, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Oct 7, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 8, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210 UltraBlame original commit: a3cf4d1eef17209c4c4194e07f38fe870c417781
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 8, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210 UltraBlame original commit: a3cf4d1eef17209c4c4194e07f38fe870c417781
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 8, 2025
…der r=jonco This patch inverts the order in which we reject promises in AsyncModuleExecutionRejected to match AsyncModuleExecutionFulfilled: first the promise corresponding to the leaf module (the one that throws) is rejected, and then its ancestors. This change was discussed at the July 2025 TC39 meeting. Spec PR: tc39/ecma262#3695 test262: tc39/test262#4591 Differential Revision: https://phabricator.services.mozilla.com/D267210 UltraBlame original commit: a3cf4d1eef17209c4c4194e07f38fe870c417781
Jack-Works
added a commit
to engine262/engine262
that referenced
this pull request
Nov 17, 2025
tc39/ecma262#3695 also fix escape parsing and update test262
caiolima
added a commit
to caiolima/v8
that referenced
this pull request
Nov 18, 2025
…t order This implements the spec change from [1]. This PR changes the order of rejections to match the same order that happens on fufillment. For detailed dicussions and reasing, check[1]. Test262 were added to match the spec as well in [2]. [1] Spec PR: tc39/ecma262#3695 [2] Test262 PR: tc39/test262#4591
caiolima
added a commit
to caiolima/v8
that referenced
this pull request
Nov 20, 2025
…t order This implements the spec change from [1]. This PR changes the order of rejections to match the same order that happens on fufillment case. First the rejection goes to the leaf module and then it bubbles up to its acenstros. For detailed dicussions and reasoning, check[1]. [1] Spec PR: tc39/ecma262#3695 [2] Test262 PR: tc39/test262#4591
Member
Author
|
Implementation status:
|
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Nov 28, 2025
This implements the spec change from [1]. This PR changes the order of rejections to match the same order that happens on fufillment case. It meansd that First the rejection goes to module where it happens and then it bubbles up to its acenstros. For detailed discussion and reasoning, check links in the PR[1]. [1] Spec PR: tc39/ecma262#3695 [2] Test262 PR: tc39/test262#4591 Bug: 433891576 Change-Id: I3b16e276ad0d6bd0c5a17f20f8db06d56b483883 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7169324 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Andy Wingo <[email protected]> Reviewed-by: Olivier Flückiger <[email protected]> Cr-Commit-Position: refs/heads/main@{#104017}
michaelficarra
approved these changes
Dec 8, 2025
bakkot
approved these changes
Dec 8, 2025
4762595 to
4752038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the normative change that reached consensus in July 2025 (slides, notes)
This is what the exact consensus request was, that this PR matches:
