Skip to content

Update Specta in lockfile to fix documentation#15177

Merged
lucasfernog merged 7 commits into
tauri-apps:devfrom
oscartbeaumont:update-specta-to-fix-docs
Apr 29, 2026
Merged

Update Specta in lockfile to fix documentation#15177
lucasfernog merged 7 commits into
tauri-apps:devfrom
oscartbeaumont:update-specta-to-fix-docs

Conversation

@oscartbeaumont

@oscartbeaumont oscartbeaumont commented Mar 30, 2026

Copy link
Copy Markdown
Member

The docs.rs build for Tauri 2.10.3 failed.

In looking into the build logs this seems to be due to a bug in the Specta.

The type implementation for [T] looked like the following:

impl<T: Type> Type for [T] {
    impl_passthrough!(Vec<T>);
}

and then the implementation of Vec<T> is the following:

#[cfg(feature = "std")] // <- notice this
impl<T: Type> Type for Vec<T> {
    ...
}

This is an issue because the implementation for Vec<T> is not available without the new std feature (which is enabled by default) breaking the implementation for [T] which shouldn't require the std feature. The std feature being enabled by default meant that it was never caught in Specta's tests, so I will need to upgrade the CI workflows! As Tauri disables default features the std feature is missing when it builds docs and this code fails to compile. In real-world applications using Tauri + Specta I doubt this will be encountered as the specta dependency being in the users Cargo.toml will likely enable the std feature.

Prior to me becoming aware of this being an issue in Tauri I had already overhaulled all the types impls so now Vec<T> dispatches to [T] which is how is how it should have always been to begin with. This PR just bumps the version to the latest release I did today to ensure we can get this issue resolved as quick as possible.

Really sorry for this breakage. Once this PR is merged we should be able to push a minor release again so the docs can be published!

@oscartbeaumont oscartbeaumont requested a review from a team as a code owner March 30, 2026 15:12
@github-actions

github-actions Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through be7aabd

There are 11 changes which include tauri with minor, @tauri-apps/api with minor, tauri-build with minor, tauri-macos-sign with patch, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-plugin with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.10.1 2.11.0
tauri-utils 2.8.3 2.9.0
tauri-macos-sign 2.3.3 2.3.4
tauri-bundler 2.8.1 2.9.0
tauri-runtime 2.10.1 2.11.0
tauri-runtime-wry 2.10.1 2.11.0
tauri-codegen 2.5.5 2.5.6
tauri-macros 2.5.5 2.5.6
tauri-plugin 2.5.4 2.6.0
tauri-build 2.5.6 2.6.0
tauri 2.10.3 2.11.0
@tauri-apps/cli 2.10.1 2.11.0
tauri-cli 2.10.1 2.11.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

FabianLars
FabianLars previously approved these changes Mar 30, 2026
lucasfernog
lucasfernog previously approved these changes Mar 30, 2026
@oscartbeaumont

Copy link
Copy Markdown
Member Author

I have extended this PR with a couple of other dependency upgrades to avoid using dependencies with doc_auto_cfg as that prevents documentation building on nightly toolchains (like what docs.rs uses).

It looks like dpi hasn't released their removal of doc_auto_cfg which was merged in rust-windowing/winit@d815bc0. Sadly this is causing issues with me building Tauri Specta docs but this can be upgraded in a follow-up PR once they do a release upstream.

These issues caused the Tauri Specta docs to fail to build in the latest release so be aware they may also cause issues for Tauri's next release.

@Legend-Master Legend-Master added the status: waiting Waiting on author label Apr 23, 2026
@Legend-Master Legend-Master added this to the 2.11 milestone Apr 23, 2026
lucasfernog
lucasfernog previously approved these changes Apr 29, 2026

@lucasfernog lucasfernog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've verified it works with https://github.com/rust-lang/docs.rs

@lucasfernog

Copy link
Copy Markdown
Member

had to revert the sha bumps, MSRV :(

@oscartbeaumont

oscartbeaumont commented Apr 29, 2026

Copy link
Copy Markdown
Member Author

I wonder if that's going to cause issues due to doc_auto_cfg? In my testing it did but I also don't know if my setup was exactly the same flags as docs.rs uses.

I suppose not much we can do and it was working so surley it will continue to work.

@lucasfernog lucasfernog merged commit 373b7e6 into tauri-apps:dev Apr 29, 2026
10 checks passed
@lucasfernog

Copy link
Copy Markdown
Member

I wonder if that's going to cause issues due to doc_auto_cfg? In my testing it did but I also don't know if my setup was exactly the same flags as docs.rs uses.

I suppose not much we can do and it was working so surley it will continue to work.

well from my docs.rs build it still worked, let's see

@lucasfernog lucasfernog mentioned this pull request Apr 29, 2026
@Legend-Master

Copy link
Copy Markdown
Contributor

Looks like be7aabd reverted the specta change?

@oscartbeaumont oscartbeaumont deleted the update-specta-to-fix-docs branch April 30, 2026 00:13
razein97 pushed a commit to razein97/tauri that referenced this pull request Apr 30, 2026
* update Specta in lockfile

* Create change-pr-15177.md

* update sha1 and sha2 dependencies

* Update changeset

* update changefile

* sha1 0.10

---------

Co-authored-by: Lucas Nogueira <lucas@tauri.app>
razein97 pushed a commit to razein97/tauri that referenced this pull request Apr 30, 2026
* update Specta in lockfile

* Create change-pr-15177.md

* update sha1 and sha2 dependencies

* Update changeset

* update changefile

* sha1 0.10

---------

Co-authored-by: Lucas Nogueira <lucas@tauri.app>
@Legend-Master Legend-Master removed the status: waiting Waiting on author label May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants