Update Specta in lockfile to fix documentation#15177
Conversation
Package Changes Through be7aabdThere are 11 changes which include tauri with minor, @tauri-apps/api with minor, tauri-build with minor, tauri-macos-sign with patch, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-cli with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
I have extended this PR with a couple of other dependency upgrades to avoid using dependencies with It looks like These issues caused the Tauri Specta docs to fail to build in the latest release so be aware they may also cause issues for Tauri's next release. |
lucasfernog
left a comment
There was a problem hiding this comment.
i've verified it works with https://github.com/rust-lang/docs.rs
|
had to revert the sha bumps, MSRV :( |
|
I wonder if that's going to cause issues due to I suppose not much we can do and it was working so surley it will continue to work. |
well from my docs.rs build it still worked, let's see |
|
Looks like be7aabd reverted the specta change? |
* update Specta in lockfile * Create change-pr-15177.md * update sha1 and sha2 dependencies * Update changeset * update changefile * sha1 0.10 --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
* update Specta in lockfile * Create change-pr-15177.md * update sha1 and sha2 dependencies * Update changeset * update changefile * sha1 0.10 --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
The docs.rs build for Tauri 2.10.3 failed.
In looking into the build logs this seems to be due to a bug in the Specta.
The type implementation for
[T]looked like the following:and then the implementation of
Vec<T>is the following:This is an issue because the implementation for
Vec<T>is not available without the newstdfeature (which is enabled by default) breaking the implementation for[T]which shouldn't require thestdfeature. Thestdfeature being enabled by default meant that it was never caught in Specta's tests, so I will need to upgrade the CI workflows! As Tauri disables default features thestdfeature is missing when it builds docs and this code fails to compile. In real-world applications using Tauri + Specta I doubt this will be encountered as thespectadependency being in the usersCargo.tomlwill likely enable thestdfeature.Prior to me becoming aware of this being an issue in Tauri I had already overhaulled all the types impls so now
Vec<T>dispatches to[T]which is how is how it should have always been to begin with. This PR just bumps the version to the latest release I did today to ensure we can get this issue resolved as quick as possible.Really sorry for this breakage. Once this PR is merged we should be able to push a minor release again so the docs can be published!