chore(deps): Update cargo-mobile2 and toml crates#15115
Conversation
Package Changes Through 34290a9There are 6 changes which include tauri-macos-sign with patch, tauri with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-utils with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
need this for #14886 |
|
we really need to stop having (0.x) external crates in our public apis, that shit's so annoying |
| ctor = "0.2" | ||
| json5 = { version = "0.4", optional = true } | ||
| # Part of public api in error type | ||
| toml = { version = "0.9", features = ["parse"] } |
There was a problem hiding this comment.
I wonder if a range would work here? (">=0.9, <=1")
There was a problem hiding this comment.
hmm, good question. I never really used these. sqlx did though with libsqlite-sys for ages (libsqlite is 0.x so should hopefully be the same?)
There was a problem hiding this comment.
but i guess it's not part of their public api
There was a problem hiding this comment.
just gonna push and see what ci says
There was a problem hiding this comment.
Probably fine for this specific case, cargo should be able to select the version that matches the version user uses in their own crates, and if the user didn't have one and the version is bumped to 1.0, the public APIs of the toml's error types didn't change from 0.9 to 1.0 so code around it should still work
If this works, it should probably also work for #14599 ?
There was a problem hiding this comment.
worth a try, want me to do it here?
There was a problem hiding this comment.
nvm, needs edition2024
Legend-Master
left a comment
There was a problem hiding this comment.
Looking at the dependency graph, we still have embed-resource, tauri-winres, cargo_toml on 0.9, not sure if it's worth waiting though
|
yeah, i'd rather not wait cause that'd mean i'd have to revert it in cargo-mobile2 😂 |
This reverts commit eda416b.
* chore(deps): Update cargo-mobile2 and toml crates * remove toml from tauri-build cargotoml * 0.22.3 * try a range * json5 and changefile * Revert "json5 and changefile" This reverts commit eda416b. * keep changefile
* chore(deps): Update cargo-mobile2 and toml crates * remove toml from tauri-build cargotoml * 0.22.3 * try a range * json5 and changefile * Revert "json5 and changefile" This reverts commit eda416b. * keep changefile
would be cool to have https://gitlab.com/lib.rs/cargo_toml/-/work_items/39 as well but idk the timeline for that