feat: Allow getting inner PathBuf from SafePathBuf#14908
Conversation
Package Changes Through 38f4e08There are 9 changes which include tauri-macos-sign with patch, tauri-build with patch, tauri with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime-wry with minor, tauri-runtime with minor, tauri-utils with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Is |
|
Legend-Master
left a comment
There was a problem hiding this comment.
Thanks, could you also add a change file?
https://github.com/tauri-apps/tauri/blob/dev/.changes/README.md
|
@Legend-Master |
SafePathBuf implements AsRef<Path> which is ergonomic and useful. However, some APIs take owned PathBufs. This leads to clunky code where the caller has to get a &Path from the SafePathBuf then take ownership of that path. Ideally, if a user has a SafePathBuf and needs a PathBuf, they won't need to allocate again just to get the inner PathBuf back.
52ff6d6 to
7cb18c8
Compare
|
Hi! Sorry for the late response. I force pushed to add a changes file. Sorry, I didn't know I needed one since the change was trivial. 😅 |
Legend-Master
left a comment
There was a problem hiding this comment.
Thanks, I will merge this after we got all the patch version bump PRs released and starting to merge for the next minor (2.11)
The change file is needed since this is a user facing change despite being trivial
* Allow getting inner PathBuf from SafePathBuf SafePathBuf implements AsRef<Path> which is ergonomic and useful. However, some APIs take owned PathBufs. This leads to clunky code where the caller has to get a &Path from the SafePathBuf then take ownership of that path. Ideally, if a user has a SafePathBuf and needs a PathBuf, they won't need to allocate again just to get the inner PathBuf back. * Apply suggestion from @Legend-Master
* Allow getting inner PathBuf from SafePathBuf SafePathBuf implements AsRef<Path> which is ergonomic and useful. However, some APIs take owned PathBufs. This leads to clunky code where the caller has to get a &Path from the SafePathBuf then take ownership of that path. Ideally, if a user has a SafePathBuf and needs a PathBuf, they won't need to allocate again just to get the inner PathBuf back. * Apply suggestion from @Legend-Master
SafePathBufimplementsAsRef<Path>which is ergonomic and useful. However, some APIs take ownedPathBufs. This leads to clunky code where the caller has to get a&Pathfrom theSafePathBufthen take ownership of that path. Ideally, if a user has aSafePathBufand needs aPathBuf, they won't need to allocate again just to get the innerPathBufback.