Use Collection instead of List as arguments type in TarantoolClient#431
Merged
Use Collection instead of List as arguments type in TarantoolClient#431
Conversation
Also replace unnecessary stream usage with less GC-pressing code in the List object converter
Replace streams usage with less GC-pressing code
Replace arguments type in call* and eval* methods to Collection. This improves the API and allows to remove redundant creation of intermediate ArrayLists on each call.
2e2b048 to
585d827
Compare
nickkkccc
approved these changes
Oct 5, 2023
ArtDu
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make some performance improvements by removing unnecessary wrapper object creation.
See individual commit messages for details about the changes.
Closes #432