Conversation
Add general enum class for using CRUD option names. Needed for #420.
- Delete NAME field from Mode, RollbackOnError, StopOnError classes. - Change inner API in OperationWith, Options interfaces, ProxySelectOptions, BaseOptions classes for using ProxyOption enum. - Change Map to EnumMap in BaseOptions class. Needed for #420.
ArtDu
reviewed
Sep 12, 2023
Contributor
ArtDu
left a comment
There was a problem hiding this comment.
Looks good. One thing I can suggest now is adding changes in changelog about this PR. You can add below an internal changes header
- Change inner API for CRUD options classes from working with ProxyOption enum class. - Change CHANGELOG.md. Closes for #420.
ArtDu
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't forgotten about:
Related issues:
Closes #420