Conversation
akudiyar
left a comment
There was a problem hiding this comment.
Changing the call method signature seems reasonable, but that's a breaking change and we must notify the customers appropriately. Changing MessagePackMapper parameter types to MessagePackValueMapper also seems reasonable.
But we shouldn't have any raw Objects in the API (List<?> in call and eval is the only exception here because of the compatibility with tarantool-java and also it's a better variant than just Object). ALso I don't get why we change CallResultMapper result types to something else.
src/main/java/io/tarantool/driver/mappers/factories/ResultMapperFactoryFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/mappers/factories/ResultMapperFactoryFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/mappers/factories/ResultMapperFactoryFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/mappers/factories/ResultMapperFactoryFactory.java
Outdated
Show resolved
Hide resolved
I added two ways of using with generics and without. Check them. |
|
@akudiyar I probably did all what we discussed. And also I updated PR in springdata(tarantool/cartridge-springdata#124). Please check both PR and give your opinion |
akudiyar
left a comment
There was a problem hiding this comment.
That's in the much better shape now. I have just three small nitpicks
src/test/java/io/tarantool/driver/integration/ProxyTarantoolClientIT.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexey Kuzin <akudiyar@gmail.com>
I haven't forgotten about:
Related issues: