Skip to content

Fix lack of closing when greeting fails#389

Merged
ArtDu merged 2 commits intomasterfrom
fix_closing
Apr 28, 2023
Merged

Fix lack of closing when greeting fails#389
ArtDu merged 2 commits intomasterfrom
fix_closing

Conversation

@ArtDu
Copy link
Copy Markdown
Contributor

@ArtDu ArtDu commented Apr 27, 2023 •
edited
Loading

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:
Closes #379

@ArtDu ArtDu requested a review from akudiyar April 27, 2023 15:51
@ArtDu ArtDu marked this pull request as ready for review April 27, 2023 15:51
@ArtDu ArtDu requested a review from bitgorbovsky April 27, 2023 15:52
akudiyar
akudiyar approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@akudiyar akudiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArtDu ArtDu merged commit 7da4e33 into master Apr 28, 2023
@ArtDu ArtDu deleted the fix_closing branch April 28, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitgorbovsky bitgorbovsky bitgorbovsky approved these changes

@akudiyar akudiyar akudiyar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Connector doesn't close connections when greeting fails

3 participants

@ArtDu @bitgorbovsky @akudiyar