Get rid of double executor in retrying

[ArtDu]

Before changing:

Benchmark                   Mode  Cnt      Score       Error  Units
BenchmarkRunner.spaceCall  thrpt    5  74844.508 ± 16460.492  ops/s

After changing:

Benchmark                   Mode  Cnt       Score        Error  Units
BenchmarkRunner.spaceCall  thrpt    5  275476.264 ± 256775.771  ops/s

• Error means mean margin between iteration:

This is the margin of error for the score. In most cases, that is a half of confidence interval. Think about it as if there is a "±" sign between "Score" and "Score error". In fact, the human-readable log will show that:

Iteration   1: 334564.445 ops/s
Iteration   2: 226016.924 ops/s
Iteration   3: 343260.667 ops/s
Iteration   4: 190627.608 ops/s
Iteration   5: 282911.676 ops/s

I haven't forgotten about:

• Tests
• Changelog
• Documentation
• Commit messages comply with the guideline
• Cleanup the code for review. See checklist

Related issues:
Closes #382

[vasilevichra]

Such a long name. Why not withRetry(3) or withAttempt(42) or withMaxTries(99)?

[ArtDu]

You're right, maybe we should rename it. Could you create a ticket for it?

[akudiyar]

This is a builder. We can make it hierarchical, but with plain structure as it is now such a long name is necessary because it specifies two options in one time: that we have a retry mechanism enabled and that we specify number of attempts as its parameter.

[akudiyar]

LGTM.

[akudiyar]

This is a builder. We can make it hierarchical, but with plain structure as it is now such a long name is necessary because it specifies two options in one time: that we have a retry mechanism enabled and that we specify number of attempts as its parameter.