Conversation
akudiyar
requested changes
Mar 29, 2023
Collaborator
akudiyar
left a comment
There was a problem hiding this comment.
LGTM, but the hard-coded version a bit scares me
| private static final Logger logger = LoggerFactory.getLogger(SharedTarantoolContainer.class); | ||
|
|
||
| protected static final TarantoolContainer container = new TarantoolContainer() | ||
| protected static final TarantoolContainer container = new TarantoolContainer("tarantool/tarantool:2.10.5-centos7") |
Collaborator
There was a problem hiding this comment.
Why do we need to hardcode the Tarantool version like this?
Contributor
Author
There was a problem hiding this comment.
I haven't finished it. Just draft 🫠
e5a3030 to
9f4a7ab
Compare
Closes #214
akudiyar
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converter can support parsing Datetime tarantool type to java Instant. Because Instant doesn't support timezone and offset we can't support full DateTime type features.
Also to test new features we need to have variants of tarantool in CI so we did:
But we have one problem with versions. Tarantool on Docker hub has fixed patches only for 2.10 version if we speak about centos versions. Besides 2.10 versions we only can use 1.x, 2.x tags. That means the latest versions, for e.g. 1.10.15, 2.10.6. Then we have two ways:
I haven't forgotten about:
Related issues:
Closes #214