Conversation
akudiyar
requested changes
Dec 15, 2022
| ); | ||
| final Map<String, String> buildArgs = new HashMap<>(); | ||
| buildArgs.put("DOWNLOAD_SDK_URI", System.getenv("DOWNLOAD_SDK_URI")); | ||
| buildArgs.put("SDK_VERSION", "tarantool-enterprise-bundle-2.10.0-beta2-91-g08c9b4963-r474"); |
Collaborator
There was a problem hiding this comment.
I guess this bundle name may change frequently, so it will have more sense to pass it as an environment variable (and therefore from the CI job environment variables).
4fe7a2c to
cc381ed
Compare
ArtDu
requested changes
Dec 19, 2022
src/test/java/io/tarantool/driver/integration/ssl/SslClientMTlsITEnterprise.java
Outdated
Show resolved
Hide resolved
ArtDu
requested changes
Dec 19, 2022
src/test/java/io/tarantool/driver/integration/ssl/SslClientITEnterprise.java
Outdated
Show resolved
Hide resolved
src/test/java/io/tarantool/driver/integration/ssl/SslClientITEnterprise.java
Outdated
Show resolved
Hide resolved
src/test/java/io/tarantool/driver/integration/ssl/SslClientMTlsITEnterprise.java
Outdated
Show resolved
Hide resolved
src/test/java/io/tarantool/driver/integration/ssl/SslClientMTlsITEnterprise.java
Outdated
Show resolved
Hide resolved
ArtDu
requested changes
Dec 19, 2022
Contributor
ArtDu
left a comment
There was a problem hiding this comment.
Please squash commits before merge
ArtDu
previously approved these changes
Dec 19, 2022
Add mTLS integration tests and resources Co-authored-by: Oleg Kuznetsov <one.byte.from@gmail.com> Closes #328
ArtDu
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mTLS integration tests and resources
I haven't forgotten about:
Related issues:
Closes #328