Change excel_ui functions to output OrderedDicts#334
Merged
castillohair merged 1 commit intotaborlab:developfrom Jun 13, 2020
JS3xton:ordereddict-outputs
Merged
Change excel_ui functions to output OrderedDicts#334castillohair merged 1 commit intotaborlab:developfrom JS3xton:ordereddict-outputs
castillohair merged 1 commit intotaborlab:developfrom
JS3xton:ordereddict-outputs
Conversation
-Change excel_ui.process_beads_table() and excel_ui.process_samples_table() to output OrderedDict data structures keyed on IDs from corresponding Beads and Samples tables. -Updated related code and documentation accordingly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
excel_ui.process_beads_table()andexcel_ui.process_samples_table()to outputOrderedDictdata structures keyed on IDs from corresponding Beads and Samples tables. Also update related code and documentation accordingly.Closes #232.
All unit tests pass in
Python 3.8 + Anaconda 2020.02andPython 2.7 + Anaconda 4.4.0.>python -m FlowCal.excel_ui -v -p -H -i ./examples/experiment.xlsxworks without error inPython 3.8 + Anaconda 2020.02andPython 2.7 + Anaconda 4.4.0. Outputs (plots and Excel file) generated before and after the change appear the same inPython 3.8 + Anaconda 2020.02.>python ./examples/analyze_excel_ui.pyworks without error inPython 3.8 + Anaconda 2020.02.