#86 Repository location stripping #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8y8
approved these changes
Sep 29, 2016
|
|
||
| if container_file is None: | ||
| container_file = new_filename | ||
| if new_filename is None: |
t8y8
reviewed
Sep 29, 2016
| return self._connections | ||
|
|
||
| def clear_repository_location(self): | ||
| tag = self._datasourceXML.find('./repository-location') |
Contributor
There was a problem hiding this comment.
Intentional that it's ./ here but .// in the test?
t8y8
suggested changes
Oct 1, 2016
Contributor
t8y8
left a comment
There was a problem hiding this comment.
One minor thing after taking a second look
tableaudocumentapi/datasource.py
Outdated
|
|
||
| def clear_repository_location(self): | ||
| tag = self._datasourceXML.find('./repository-location') | ||
| self._datasourceXML.remove(tag) |
Contributor
There was a problem hiding this comment.
This will fail and throw a TypeError if the find returns None -- eg if you call this method twice or it never had a repository-location tag.
Do we just want this to return silently instead of blowing up?
Contributor
Author
There was a problem hiding this comment.
Oh dang that was supposed to have an if tag: on it
t8y8
approved these changes
Oct 4, 2016
Contributor
|
🚀 🌕 ⏯️ 🌠 |
graysonarts
pushed a commit
that referenced
this pull request
Oct 7, 2016
* Add the ability to clear repository location on the datasource for retargetting * fixing a pep8 issue that was missed * Adding None check for repository-location in case it doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #86