Skip to content

address lack of coverage from #63 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graysonarts merged 1 commit into from
Jul 27, 2016
Merged

address lack of coverage from #63 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions tableaudocumentapi/multilookup_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,25 @@ def _populate_indexes(self):
self._indexes['alias'] = _build_index('alias', self)
self._indexes['caption'] = _build_index('caption', self)

def _get_real_key(self, key):
if key in self._indexes['alias']:
return self._indexes['alias'][key]
if key in self._indexes['caption']:
return self._indexes['caption'][key]

return key

def __setitem__(self, key, value):
real_key = self._get_real_key(key)

alias = _resolve_value('alias', value)
caption = _resolve_value('caption', value)
if alias is not None:
self._indexes['alias'][alias] = key
self._indexes['alias'][alias] = real_key
if caption is not None:
self._indexes['caption'][caption] = key
self._indexes['caption'][caption] = real_key

dict.__setitem__(self, key, value)
dict.__setitem__(self, real_key, value)

def get(self, key, default_value=_no_default_value):
try:
Expand All @@ -58,9 +68,5 @@ def get(self, key, default_value=_no_default_value):
raise

def __getitem__(self, key):
if key in self._indexes['alias']:
key = self._indexes['alias'][key]
elif key in self._indexes['caption']:
key = self._indexes['caption'][key]

return dict.__getitem__(self, key)
real_key = self._get_real_key(key)
return dict.__getitem__(self, real_key)
9 changes: 9 additions & 0 deletions test/test_multidict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,12 @@ def test_multilookupdict_get_returns_default_value(self):
def test_multilookupdict_get_returns_value(self):
actual = self.mld.get('baz')
self.assertEqual(1, actual['value'])

def test_multilookupdict_can_set_item(self):
before = self.mld['baz']
self.mld['baz'] = 4
self.assertEqual(4, self.mld['baz'])

def test_multilookupdict_can_set_new_item(self):
self.mld['wakka'] = 1
self.assertEqual(1, self.mld['wakka'])