add shape property

[dev-mkc19]

Adding ability to get shapes name from workbook

[dev-mkc19]

@RussTheAerialist hello! I would like to being part of contributors by added some improvements. But my merge request is still opened. What should I do to speed up this process?

[jacalata]

Hi @dev-mkc19 - sorry for the long silence. If you're still interested, could you add a test or a sample that shows your change working?

[bcantoni]

Confirmed we've received the CLA from @dev-mkc19, so we are all set on that part of this PR.

[dev-mkc19]

@jacalata I added some tests and rebase my commits to be up to date, but think it wasn't good idea because some waste commits is included. What do you think?

[jacalata]

I'm going to try rebasing this onto the dev branch, and that should get rid of all the unnecessary commits. If you would like to do that yourself then of course go ahead 😀

[dev-mkc19]

No problem, I’ll do this. But I want to be sure that my work won’t be wasted, because 1,5 year for PR it’s crazy loooong.

[jacalata]

It is. I will release it myself.

…

On Wed, Oct 6, 2021 at 6:36 AM dev-mkc19 ***@***.***> wrote: No problem, I’ll do this. But I want to be sure that my work won’t be wasted, because 1,5 year for PR it’s crazy loooong. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#178 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPKU6B2HNROQRBQO7X6MLLUFRGEPANCNFSM4MQ6KIVQ> .

[dev-mkc19]

@jacalata Just remember that I'm still waiting 😃

[jacalata]

I remember!

[jacalata]

And there you go, 0.8 :) It'll go up on pypi during the week.

[dev-mkc19]

Yeah, already saw the release. It's cool. Hope to be able to bring some more benefits.