adding oracle param support related to #137 #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8y8
suggested changes
Apr 25, 2018
Contributor
t8y8
left a comment
There was a problem hiding this comment.
The getter has a copy/paste error causing a test failure.
Also, have you filled out the CLA? (There's a lag between you sending and me getting the notification, so apologies if you have)
tableaudocumentapi/connection.py
Outdated
| @property | ||
| def service(self): | ||
| """Database service for the connection. Not the table name.""" | ||
| return self._schema |
Contributor
There was a problem hiding this comment.
copy/paste error? I think this should be self._service :)
Contributor
Author
|
Don't have the CLA, will email it in today |
t8y8
approved these changes
Apr 27, 2018
Contributor
t8y8
left a comment
There was a problem hiding this comment.
🚀
I received the CLA as well, thank you!
Contributor
|
@KevinGlinski can you make this against the 'development' branch? I didn't catch that before I hit merge, but may as well fix it now :) |
jacalata
pushed a commit
that referenced
this pull request
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.