Skip to content

Throw an exception on empty response #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicekiwi merged 1 commit into from
Apr 27, 2024
Merged

Throw an exception on empty response #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Syntax/SteamApi/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,11 @@ protected function sendRequest(Request $request)
} catch (Exception $e) {
throw new ApiCallFailedException($e->getMessage(), $e->getCode(), $e);
}

// For some resources, the Steam API responds with an empty response
if (empty($result->body)) {
throw new ApiCallFailedException('API call failed due to empty response', $result->code);
}

// If all worked out, return the result
return $result;
Expand Down