Skip to content

Add missing types dependency #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wooorm merged 1 commit into from
Nov 19, 2021
Merged

Add missing types dependency #4

wooorm merged 1 commit into from
Nov 19, 2021

Conversation

@alvinleung1996
Copy link
Contributor

@alvinleung1996 alvinleung1996 commented Nov 19, 2021 •
edited
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Add missing @types/unist dependency in package.json so that interfaces in complex-types.d.ts can work correctly under Yarn strict PnP mode.

Fix #3.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Nov 19, 2021
@wooorm wooorm changed the title Add missing @types/unist dependency in package.json Add missing types dependency Nov 19, 2021
@wooorm wooorm merged commit de3a093 into syntax-tree:main Nov 19, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Nov 19, 2021
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added ☂️ area/types This affects typings 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix labels Nov 19, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Nov 19, 2021
@wooorm
Copy link
Member

wooorm commented Nov 19, 2021

Thanks Alvin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm approved these changes

Assignees

No one assigned

Labels

☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing @types/unist in package.json dependencies

2 participants

@alvinleung1996 @wooorm