Conversation
This comment has been minimized.
This comment has been minimized.
919e450 to
8c8e243
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@claude create a checklist of manual test flows |
This comment has been minimized.
This comment has been minimized.
1170e77 to
b0e40c3
Compare
There was a problem hiding this comment.
Test 1
Ran successfully the 1st pass of tests: switching and receiving to each address type as configurable in settings.
@ben-kaufman
I noticed the Address Viewer only knows the native segwit address type. Maybe worth updating it with implementation matching the former react native functionality which allowed switching address type on that screen. Probably best done on another PR to keep the changes reviewable; can be stacked PR, targeting the branch of this one.
|
@ovitrif I just updated the address viewer here since it was a very small change |
jvsena42
left a comment
There was a problem hiding this comment.
Didn't find any actual bug, just some suggestions
Still testing...
| do { | ||
| let newAddress = try await lightningService.newAddressForType(addressType) | ||
|
|
||
| UserDefaults.standard.set(newAddress, forKey: "onchainAddress") |
There was a problem hiding this comment.
nit could check defensively if the address matches the addressType before saving it and even add unit tests
21fca73 to
dc1ab2a
Compare
|
@jvsena42 updated for all comments |
Co-authored-by: João Victor Sena <jvsena42@users.noreply.github.com>
|
I didn't know that Claude would automatically commit 😶🌫️ |
|
❌After send 1k sats of native segwit, the amount was subtracted but the activity was not displayed. Steps to reproduce:
Testing in emulator, IDK if it is possible to export the logs. When I finish the tests I can share the mnemonics but the logs are just local I'm not sure if it is related to this branch |
d436239 to
8956313
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
❌ Nested Segwit Send activity not displayed Also tested mine one block Simulator.Screen.Recording.-.iPhone.16.-.2026-02-19.at.07.34.17.mp4
|
|
❌ Send Legacy activity not displayed Simulator.Screen.Recording.-.iPhone.16.-.2026-02-19.at.08.39.30.mp4
bitkit_foreground_2026-02-19_11-20-12.log |
This PR adds support for multiple Bitcoin address types in the iOS app, allowing users to select and monitor different address formats. Users can select their preferred address type from: Legacy (P2PKH), Nested SegWit (P2SH-P2WPKH), Native SegWit (P2WPKH), and Taproot (P2TR).
This requires extensive testing across all functionalities, send, receive, channel open, channel close (funds should always go to native segwit address except when selected address when channel opened was Taproot, in which case it should be a Taproot address), cpfp, rbf. All should be checked for each address type, and for multiple address types combined (ie. send with utxos of different address types, open channel with inputs of different address types, boost txs with inputs of different address types, etc.)