Skip to content

Conversation

@sxyazi
Copy link
Owner

@sxyazi sxyazi commented Dec 11, 2024

An implementation of the feature request: #2026

Closes #2026

# yazi.toml
[manager]
_v4_suppress_deprecation_warnings = true

@sxyazi sxyazi merged commit ccf466d into main Dec 11, 2024
6 checks passed
@sxyazi sxyazi deleted the pr-4ad1dc9a branch December 11, 2024 09:38
@sxyazi sxyazi mentioned this pull request Dec 11, 2024
3 tasks
@uncenter
Copy link
Contributor

Why is this version specific? Wouldn't it make sense to have it as a permanent field?

@sxyazi
Copy link
Owner Author

sxyazi commented Dec 12, 2024

You mean using suppress_deprecation_warnings instead of _v4_suppress_deprecation_warnings?

The issue with this is that if a user enabled it in v0.4 and forgot to remove it, since it's not version-specific, they won't even see the deprecation warnings for the v0.5 API when they upgrade to v0.5.

As a result, they might run into issues when the v0.5 API compatibility layer is completely removed, without realizing it.

@uncenter
Copy link
Contributor

This seems like a hack though. Maybe "suppress_deprecation_warnings" has a value like "0.4" where it targets warnings in that range? Just something more dynamic. I'd hate to see this be removed and then requested again and brought back for v5... etc.

@sxyazi
Copy link
Owner Author

sxyazi commented Dec 12, 2024

My plan is to remove this option when removing the 0.4 compatibility layer, since it feels weird to still have a suppress_deprecation_warnings if all the compatibility code (warnings) is gone as there's nothing left to "suppress".

If we're going to make it permanent, we'd need to reconsider its name and position, placing it under [manager] feels odd.

Like the [headsup] and disable_exec_warn option introduced in 0.3, which were eventually removed along with the compatibility code though.

Overall, I think making it permanent is a bit of an overkill, especially since it's just a temporary workaround for the transition.

@uncenter
Copy link
Contributor

Speaking as the person who edits the schemas adding all these temporary config options is not a good solution 😅
Maybe add an option in the TUI itself that toggles an internal state property, so outside of the config? It can be like this, for a specific version, and cleared by Yazi by later versions.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 21, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sxyazi/yazi](https://github.com/sxyazi/yazi) | patch | `v0.4.1` -> `v0.4.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>sxyazi/yazi (sxyazi/yazi)</summary>

### [`v0.4.2`](https://github.com/sxyazi/yazi/releases/tag/v0.4.2)

[Compare Source](sxyazi/yazi@v0.4.1...v0.4.2)

This is a quick patch release with 3 fixes:

-   Fixed an issue where switching directories in Yazi didn't update the CWD, causing issues with features that depend on the CWD (like terminal splitting and `cd --interactive` path completion).
-   Fixed a bug where the UI wouldn't refresh when returning to Yazi from an external blocking process (like a shell) while in an empty directory.
-   Fixed an issue where the preview wouldn't update after sorting directories when using the [Folder-specific rules](https://yazi-rs.github.io/docs/tips/#folder-rules) tip.

Here are some new features:

-   Added support for a large number of new archive formats for extraction, previewing, and filetype highlighting in sxyazi/yazi#1926 (thanks to [@&#8203;Integral-Tech](https://github.com/Integral-Tech)).
-   Added a new temporary option `_v4_suppress_deprecation_warnings` in [#&#8203;2027](sxyazi/yazi#2027) to suppress all deprecation warnings as a workaround for the transition to version 0.4:
    ```toml
    ```

### yazi.toml

\[manager]
\_v4\_suppress_deprecation_warnings = true

    - Added 2 new Lua APIs
    - `fs.cwd()` - get the current working directory
    -  `fs.create()` - create a directory (Thanks to @&#8203;hankertrix)
    #### What's Changed
    * fix: interactive `cd` autocomplete doesn't follow the latest `CWD` changes by @&#8203;sxyazi in sxyazi/yazi#2025
    * feat: new option to suppress 0.4 deprecation warnings by @&#8203;sxyazi in sxyazi/yazi#2027
    * fix: offset cursor shift when deleting multiple files in bulk by @&#8203;sxyazi in sxyazi/yazi#2030
    * chore: bump version to 0.4.2 by @&#8203;sxyazi in sxyazi/yazi#2031
    * fix: choose a more conservative `macro_workers` value to ensure concurrency safety with certain USB flash drives by @&#8203;sxyazi in sxyazi/yazi#2040
    * feat: support for Android platform in the `for` qualifier of opener by @&#8203;sxyazi in sxyazi/yazi#2041
    * fix: set the current working directory in a thread-safe way by @&#8203;sxyazi in sxyazi/yazi#2043
    * fix: `allow-passthrough` must be set to `on` to prevent `tmux` from forwarding the real terminal's response to the inactive pane by @&#8203;sxyazi in sxyazi/yazi#2052
    * fix: pass through `show_hidden` when building default `Files` by @&#8203;sxyazi in sxyazi/yazi#2057
    * fix: use a less intrusive `DSR` instead of `DA1` workaround to forward terminal responses twice in `tmux` by @&#8203;sxyazi in sxyazi/yazi#2058
    * feat: new `--cwd` parameter for the `shell` command and `fs.cwd()` API by @&#8203;sxyazi in sxyazi/yazi#2060
    * feat: allow `noop` for single-key chords by removing the mixing length limit by @&#8203;sxyazi in sxyazi/yazi#2064
    * ci: add riscv64gc-unknown-linux-gnu target by @&#8203;Integral-Tech in sxyazi/yazi#2067
    * fix: missing a render after resuming from an external blocking process by @&#8203;sxyazi in sxyazi/yazi#2071
    * feat: add more supported archive formats to the preset config by @&#8203;Integral-Tech in sxyazi/yazi#1926
    * feat: new `fs.create()` Lua API by @&#8203;hankertrix in sxyazi/yazi#2068
    * fix: missing a hover after reordering from an external plugin by @&#8203;sxyazi in sxyazi/yazi#2072

    **Full Changelog**: sxyazi/yazi@v0.4.1...v0.4.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Ny4wIiwidXBkYXRlZEluVmVyIjoiMzkuNzcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suppress deprecation warnings

3 participants