refactor: replace format! with concat! for string literals
#2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxyazi
reviewed
Dec 8, 2024
ac7fb09 to
97c53bf
Compare
Contributor
Author
|
@sxyazi Done :) |
sxyazi
reviewed
Dec 8, 2024
1394fb4 to
62ac224
Compare
format! with concat! for string literals
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Dec 11, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [sxyazi/yazi](https://github.com/sxyazi/yazi) | patch | `v0.4.0` -> `v0.4.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sxyazi/yazi (sxyazi/yazi)</summary> ### [`v0.4.1`](https://github.com/sxyazi/yazi/releases/tag/v0.4.1) [Compare Source](sxyazi/yazi@v0.4.0...v0.4.1) This is a quick patch version with 4 fixes: - Fixed an issue where Yazi would freeze when waiting for terminal response, in old tmux versions (v3.2a or lower), or 2-layer nested terminal setup (tmux -> Neovim's `:terminal` -> Yazi). - Fixed a bug in the Überzug++ backend where certain image dimension parsing failed, preventing images from displaying. - Fixed a build failure for Android 32-bit architectures. - Fixed an issue with the preset `archive` and `json` plugins not handling CRLF properly on Windows. #### What's Changed - fix: disable passthrough when the user launches Yazi in Neovim inside tmux by [@​sxyazi](https://github.com/sxyazi) in sxyazi/yazi#2014 - refactor: replace `format!` with `concat!` for string literals by [@​Integral-Tech](https://github.com/Integral-Tech) in sxyazi/yazi#2012 - fix: correctly handle CRLF on Windows in preset `archive` and `json` plugins by [@​sxyazi](https://github.com/sxyazi) in sxyazi/yazi#2017 - fix: failed to parse certain image dimensions for Überzug++ backend by [@​sxyazi](https://github.com/sxyazi) in sxyazi/yazi#2020 - chore: bump version to 0.4.1 by [@​sxyazi](https://github.com/sxyazi) in sxyazi/yazi#2022 **Full Changelog**: sxyazi/yazi@v0.4.0...v0.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format!macro is very powerful, it introduces overhead of memory allocation on the heap compared to&str. Therefore, whenformat!macro is unnecessary, we should avoid using it.