chore: move common dependencies to workspace Cargo.toml #1388
Conversation
|
Thanks for the PR! Every crate of Yazi gets published to crates.io, will this have any impact on it? |
|
I don't believe it should cause any issues. quickwit makes use of workspace dependencies, and their crates get published as well. |
Nice, TIL about that. |
| color_quant = "1.1.0" | ||
| crossterm = "0.27.0" | ||
| futures = "0.3.30" | ||
| crossterm = { workspace = true } |
There was a problem hiding this comment.
We can't use { workspace = true } here because the "use-dev-tty" feature can only be enabled on macOS systems.
There was a problem hiding this comment.
Ah, I see. I hadn't realized. I pushed a fix. { workspace = true, features = [ "use-dev-tty" ] } lets the version be defined once in the root Cargo.toml, but with additive features. Details here: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-dependencies-table
33d04f9 to
3fdbbfe
Compare
It's easier to keep versions in sync across the entire workspace this way.