AH rewrite: Add function to invoke AH callbacks #6776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
Jul 21, 2025
|
|
||
| namespace ah { | ||
| template <typename HorizonMetavars, typename DbTags, typename Metavariables> | ||
| void invoke_callbacks(const gsl::not_null<db::DataBox<DbTags>*> box, |
| new_interpolated_vars->initialize(current_ylm.physical_size()); | ||
| tmpl::for_each<ah::vars_to_interpolate_to_target<3, Fr>>( | ||
| [&](auto tag_v) { | ||
| using tag = typename decltype(tag_v)::type; |
Member
There was a problem hiding this comment.
[optional] Use an explicit template argument. A few other places as well.
| }); | ||
|
|
||
| // Time deriv is zero because there weren't any previous horizons to come | ||
| // the time deriv with |
| *horizon = current_strahlkorper; | ||
|
|
||
| // This is a hack to use ylm::time_deriv_of_strahlkorper function below | ||
| std::deque<std::pair<double, ylm::Strahlkorper<Fr>>> |
Member
There was a problem hiding this comment.
Not ideal, but it should be cheap compared to the horizon-find, so probably OK.
Contributor
Author
There was a problem hiding this comment.
Yeah when we do a profile, we can see if it pops up
wthrowe
requested changes
Jul 22, 2025
Member
wthrowe
left a comment
There was a problem hiding this comment.
Looks good except for one typo. Squash.
| * | ||
| * \details Before invoking the callbacks, this function | ||
| * | ||
| * 1. Restricts the final interpolated variables from the $L_\mathrm{mesh}$ use |
Contributor
Author
|
Done! |
3 tasks
wthrowe
approved these changes
Jul 23, 2025
Member
|
The Kokkos build had a number of odd failures (even more than usual), but none of them look plausibly related to these changes, so I'm ignoring them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Tenth PR in horizon finder changes. Adds a function that sets up the databox for callbacks to be run. Actual callbacks will be added in future PRs.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments