Skip to content

Remove AnalyticSolutionOrData base tag #6766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsdeppe merged 8 commits into from
Jul 17, 2025
Merged

Remove AnalyticSolutionOrData base tag #6766

nilsdeppe merged 8 commits into from
Jul 17, 2025

Conversation

@nilsdeppe
Copy link
Member

@nilsdeppe nilsdeppe commented Jul 16, 2025

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

kidder
kidder requested changes Jul 16, 2025
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can squash

src/Evolution/Systems/CurvedScalarWave/Initialize.hpp Outdated
typename flat_variables_tag::tags_list{});
call_with_dynamic_type<void, DerivedClasses>(
&solution_or_data,
// &db::get<evolution::initial_data::Tags::InitialData>(box),
Copy link
Member

@kidder kidder Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Member Author

@nilsdeppe nilsdeppe Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, done!

@nilsdeppe nilsdeppe force-pushed the remove_hydro_analytic_base_tag branch from 6627ecf to 2d1eee5 Compare July 16, 2025 21:11
@nilsdeppe nilsdeppe merged commit f048548 into sxs-collaboration:develop Jul 17, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kidder kidder kidder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nilsdeppe @kidder