Get rid of more base tags #6756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No other simple tag derived from a base tag defines this alias.
wthrowe
reviewed
Jul 14, 2025
| struct ObserveCentersBase : db::BaseTag {}; | ||
|
|
||
| /// Simple tag for whether to write the centers of the horizons to disk. | ||
| /// Currently this tag is not creatable by options |
Member
There was a problem hiding this comment.
I've checked that this was done :)
This will allow removal of base tags whose derived simple tags share the same type, but differ in how they are created from option tags. The former base tag will become the simple tag with a type alias `type` to the common type. The former derived simple tags will no longer be derived from db::SimpleTag, no longer have a type alias `type`, but now have a type alias `base` to the former base tag.
nilsdeppe
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Eliminate several uses of base tags whose derived simple tags had the same
typealias.basetype alias. This allows choosing at compile time one of the different methods that a simple tag can be created from options.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments