AH rewrite: Add initialization action and component #6752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
Jul 11, 2025
| ylm::Strahlkorper<Frame::Grid>{4, 2.0, std::array{0.0, 0.0, 0.0}}, | ||
| expected_fast_flow, ::Verbosity::Debug, 3, std::nullopt}}}; | ||
|
|
||
| const Parallel::GlobalCache<MockMetavariables>& cache_reference = cache; |
| using return_tags = | ||
| tmpl::list<Tags::Verbosity, Tags::FastFlow, Tags::CurrentTime>; | ||
|
|
||
| using argument_tags = tmpl::list<Parallel::Tags::GlobalCache<Metavariables>>; |
Member
There was a problem hiding this comment.
Just request Tags::ApparentHorizonOptions<HorizonMetavars> directly, since const cache tags are in the DataBox. I believe then you don't need to template the struct on Metavariables.
Contributor
Author
|
Rebased and no longer dependent |
Member
|
Looks good. Squash. |
wthrowe
approved these changes
Jul 13, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fifth PR in the horizon finder changes. Adds an initialization action with adds all the tags to the box, and the component for the horizon finder.
Depends on and includes #6751.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments