Revert reordering of tildeB fluxes and sources in ValenciaDivClean #6750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
An earlier PR (#5960) had reordered the source and flux terms in
ValenciaDivCleanin an attempt to make the system better-behaved. However, it was empirically found that this reduced the quality of the magnetic field evolution. Additionally, convergence tests for higher order FD do not work properly unless this change is undone.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments
@jyoo1042 This PR should merge into develop a change that you are already using. Please confirm that this is indeed the case. And if so, this will formally implement it, so you can disregard the local change that you are using.