-
Notifications
You must be signed in to change notification settings - Fork 213
Add adaptive horizon criterion for residual #6732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
knelli2
merged 1 commit into
sxs-collaboration:develop
from
geoffrey4444:AhCriteriaResidual
Jul 14, 2025
Merged
Add adaptive horizon criterion for residual #6732
knelli2
merged 1 commit into
sxs-collaboration:develop
from
geoffrey4444:AhCriteriaResidual
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Neither test failure appears relevant to this PR |
1b9f754 to
c407c45
Compare
knelli2
requested changes
Jul 10, 2025
src/ParallelAlgorithms/ApparentHorizonFinder/Criteria/Residual.hpp
Outdated
Show resolved
Hide resolved
tests/Unit/ParallelAlgorithms/ApparentHorizonFinder/Criteria/Test_Residual.cpp
Outdated
Show resolved
Hide resolved
tests/Unit/ParallelAlgorithms/ApparentHorizonFinder/Criteria/Test_Residual.cpp
Outdated
Show resolved
Hide resolved
knelli2
reviewed
Jul 11, 2025
Contributor
knelli2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can squash everything together
src/ParallelAlgorithms/ApparentHorizonFinder/Criteria/Residual.hpp
Outdated
Show resolved
Hide resolved
tests/Unit/ParallelAlgorithms/ApparentHorizonFinder/Criteria/Test_Residual.cpp
Outdated
Show resolved
Hide resolved
bc51f94 to
924464d
Compare
knelli2
requested changes
Jul 11, 2025
Contributor
knelli2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one final thing. Can be squashed
src/ParallelAlgorithms/ApparentHorizonFinder/Criteria/Residual.cpp
Outdated
Show resolved
Hide resolved
924464d to
ed771b5
Compare
knelli2
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a criterion for adaptive horizon finding that adjusts resolution based on the residual of the most recent horizon find.
Depends on #6689 .
Note: I used the Cursor AI editor when preparing this PR, including tab completions and (for developing the first draft of the unit tests) agent mode. I reviewed all suggested code changes for correctness, and to the best of my knowledge, none of the code in this PR is from another codebase or violates any copyright or license.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments