Skip to content

Conversation

@geoffrey4444
Copy link
Contributor

Proposed changes

Adds a criterion for adaptive horizon finding that adjusts resolution based on the residual of the most recent horizon find.

Depends on #6689 .

Note: I used the Cursor AI editor when preparing this PR, including tab completions and (for developing the first draft of the unit tests) agent mode. I reviewed all suggested code changes for correctness, and to the best of my knowledge, none of the code in this PR is from another codebase or violates any copyright or license.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@geoffrey4444 geoffrey4444 added this to the AH finder improvements milestone Jul 6, 2025
@geoffrey4444 geoffrey4444 self-assigned this Jul 6, 2025
@geoffrey4444 geoffrey4444 added the dependent Needs a different PR to be merged in first label Jul 6, 2025
@geoffrey4444 geoffrey4444 changed the title Ah criteria residual Add adaptive horizon criterion for residual Jul 6, 2025
@geoffrey4444
Copy link
Contributor Author

Neither test failure appears relevant to this PR

@knelli2 knelli2 removed the dependent Needs a different PR to be merged in first label Jul 10, 2025
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash everything together

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one final thing. Can be squashed

@knelli2 knelli2 merged commit a279947 into sxs-collaboration:develop Jul 14, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants