Skip to content

Conversation

@michaeldmurphy1
Copy link
Contributor

Proposed changes

The first commit is to allow a Mesh to take a Cartoon basis which can only ever have one grid point.

The second commit uses Michael Pajkos's Cartoon code to find partial derivatives not in the computational domain. As we divide by the coordinates, if there is a zero value, L'Hopital's rule is used to evaluate the derivative at that point.

Within PartialDeriatives.tpp, cartoon_contraction() does the contractions in Eqn. (218) of the SXS book's Numerical Method's chapter, specifically the thing on the RHS that you take the derivative of or divide by x. The cartoon_derivative() function does the bottom choice of Eqn. 218 (dividing by x) while the top choice is evaluated if needed at the bottom of cartoon_partial_derivatives_apply(). One only ever calls cartoon_partial_derivatives().

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@michaeldmurphy1 michaeldmurphy1 force-pushed the cartoon_partial_deriv branch 5 times, most recently from 057e27a to 8e11cc6 Compare July 7, 2025 14:04
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work on this! This is very technical code and I think you did a fantastic job. I have quite a few suggestions, but many are stylistic and you'll just get used to them :)

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few minor typos, please rebase on develop, squash your commits appropriately, and also squash the minor changes immediately (no need to have a separate fixup commit for them)

@michaeldmurphy1 michaeldmurphy1 force-pushed the cartoon_partial_deriv branch from 46510f6 to c6556d3 Compare July 21, 2025 16:00
@nilsdeppe nilsdeppe merged commit 8d86bf5 into sxs-collaboration:develop Jul 21, 2025
23 of 24 checks passed
@michaeldmurphy1 michaeldmurphy1 deleted the cartoon_partial_deriv branch July 22, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants