Skip to content

Conversation

@iago-mendes
Copy link
Member

Proposed changes

This PR optimizes BBH ID control for hyperbolic encounters. This is done by initializing the control Jacobian with the expected couplings of the conformal masses with the ADM energy and momentum. When we start with a diagonal Jacobian, these couplings appear later. By starting with these off-diagonal terms, we've been able to decrease the number of iterations by half in some cases.

This PR also modifies the ID control output. Now, there's an H5 file ControlParams.h5, which holds Residuals.dat and Jacobian.dat. Both dat files follow the standard SXS dat format.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@iago-mendes iago-mendes requested a review from nilsvu June 17, 2025 22:26
@nilsvu nilsvu merged commit bfafc0d into sxs-collaboration:develop Jun 18, 2025
23 of 24 checks passed
@iago-mendes iago-mendes deleted the EJ-control branch June 18, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants