Skip to content

Conversation

@jyoo1042
Copy link
Contributor

Proposed changes

This PR adds a new action in ReconstructionCommunication. The action enables special handling for generating the ghost data when EnableExtensionDirection is set to true in SubcellOptions. If not enabled, the action does nothing.

In curved meshes, some ghost points may fall outside the immediate face neighbor, leading to extrapolation.
When extension directions enabled, the action extends the face neighbor's volume data using ghost data from an additional neighbor (in the extension direction), allowing for interpolation instead of extrapolation.

Note: Extension in two or more directions is not currently supported. Also, EnableExtensionDirection can only be used when AlwaysUseSubcell is true.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@jyoo1042 jyoo1042 requested a review from nilsdeppe June 16, 2025 14:58
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixups lgtm, please rebase and squash!

@nilsdeppe nilsdeppe merged commit b93388e into sxs-collaboration:develop Jul 1, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants