Skip to content

Conversation

@AlexCarpenter46
Copy link
Contributor

@AlexCarpenter46 AlexCarpenter46 commented May 28, 2025

Proposed changes

Adds a constructor to replay a function of time from volume data allowing access to all the history and updates of the function of time. This is needed for the transition to ringdown translation function of time.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@AlexCarpenter46 AlexCarpenter46 requested a review from knelli2 May 28, 2025 21:57
@AlexCarpenter46 AlexCarpenter46 marked this pull request as draft May 28, 2025 22:34
@AlexCarpenter46 AlexCarpenter46 force-pushed the replay_fot branch 2 times, most recently from a68d639 to fb55a04 Compare May 29, 2025 19:27
@AlexCarpenter46 AlexCarpenter46 changed the title Add option for replay FoTs in domain creators Add constructor for replay FoT in FromVolumeFile May 29, 2025
@AlexCarpenter46 AlexCarpenter46 marked this pull request as ready for review May 29, 2025 19:29
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash in the change. Also just NOLINT the clang-tidy error

@knelli2 knelli2 merged commit 5ebba2c into sxs-collaboration:develop Jun 2, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants