Skip to content

Conversation

@guilara
Copy link
Contributor

@guilara guilara commented May 25, 2025

Proposed changes

  • Add extra 3+1 quantities to compute curvature scalars.
  • Disable backreaction for consistency with the test-field approximation.
  • Change ScalarSource compute tag to include the coupling to curvature.
  • Update evolution executable for single black hole (among these changes, including control systems).

Depends on: #6155 #6647 #6638 #6650

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@guilara guilara added the dependent Needs a different PR to be merged in first label May 25, 2025
@guilara guilara force-pushed the PRs-ScalarTensor-UpdateExec branch from a950749 to be81e28 Compare May 26, 2025 14:40
@guilara guilara mentioned this pull request May 27, 2025
3 tasks
@guilara guilara force-pushed the PRs-ScalarTensor-UpdateExec branch 4 times, most recently from 1f15428 to 40fc4ed Compare June 6, 2025 11:40
@guilara guilara removed the dependent Needs a different PR to be merged in first label Jun 6, 2025
@guilara guilara force-pushed the PRs-ScalarTensor-UpdateExec branch 4 times, most recently from 41fbbf7 to 90a04db Compare June 6, 2025 14:20
@guilara guilara force-pushed the PRs-ScalarTensor-UpdateExec branch from 742d5ae to e40dc46 Compare June 6, 2025 15:06
@guilara guilara force-pushed the PRs-ScalarTensor-UpdateExec branch from e40dc46 to 080e1a6 Compare June 6, 2025 15:10
@guilara guilara marked this pull request as ready for review June 6, 2025 15:10
@guilara guilara requested a review from nilsdeppe June 6, 2025 16:16
struct InitializeGhAnd3Plus1Variables {
static constexpr size_t volume_dim = 3;
using frame = Frame::Inertial;
using compute_tags = db::AddComputeTags<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not asking for a change, just a note: we've been trying to have fewer compute tags during the evolution (during observing is fine!) because the RAM/memory used by the compute tags is persistent. Instead, we've tried to move more (ideally all) of the computation that is only needed for the time derivative to that computation. This reduces the amount of persistent memory significantly and will be very important for GPUs where there's a lot less RAM for the amount of given compute.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Its probably not too complicated here but wouldn't do it right now because I need to work out how to move the compute tags for the full system with backreaction.

@nilsdeppe nilsdeppe merged commit df48518 into sxs-collaboration:develop Jun 9, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants