Add geodesic equation for null rays #6646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57188f7 to
4dfbd40
Compare
wthrowe
requested changes
Jun 2, 2025
docs/References.bib
Outdated
| } | ||
|
|
||
| @article{Bohn:2014xxa, | ||
| author = {Bohn, Andy and Throwe, William and H\'ebert, Fran and |
| * parameter) $\tau$, and four-momentum $p^\mu = dx^\mu / d\tau$, we first | ||
| * define the momentum variable | ||
| * \begin{equation} | ||
| * \pi_i = \frac{p_i}{\alpha p^0} = \frac{p_i}{\sqrt{\gamma^{jk} p_j p_k}} |
Member
There was a problem hiding this comment.
Any particular reason for using \pi instead of the references' \Pi? Not wrong, of course, but seems an odd change.
wthrowe
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the formulation of the geodesic equation used for ray tracing in https://arxiv.org/abs/1410.7775.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments