Add spatial covariant derivative of extrinsic curvature #6645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add compute tag for the spatial covariant derivative of the extrinsic curvature.
To compute WeylMagnetic (magnetic part of the Weyl tensor) we need the Spatial Covariant derivative of the Extrinsic curvature. The compute tag for WeylMagnetic was previously requiring the (partial) derivative of the extrinsic curvature. Despite the LeviCivita symbol in the definition of the WeylMagnetic, there are still terms proportional to the 3-Christoffel symbols that do not cancel. I replace the incorrect argument tag in WeylMagneticCompute. This compute tag was not used anywhere in the code.
Note: I just noticed there was already a function to compute it from gh variables, but I think I cannot make a useful compute Tag with it (bc of the partial derivatives of the gh quantities).
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments