Skip to content

Conversation

@guilara
Copy link
Contributor

@guilara guilara commented May 23, 2025

Proposed changes

Add compute tag for the spatial covariant derivative of the extrinsic curvature.

To compute WeylMagnetic (magnetic part of the Weyl tensor) we need the Spatial Covariant derivative of the Extrinsic curvature. The compute tag for WeylMagnetic was previously requiring the (partial) derivative of the extrinsic curvature. Despite the LeviCivita symbol in the definition of the WeylMagnetic, there are still terms proportional to the 3-Christoffel symbols that do not cancel. I replace the incorrect argument tag in WeylMagneticCompute. This compute tag was not used anywhere in the code.

Note: I just noticed there was already a function to compute it from gh variables, but I think I cannot make a useful compute Tag with it (bc of the partial derivatives of the gh quantities).

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@guilara guilara changed the title P rs grad extrinsic curvature Add covariant derivative of extrinsic curvature May 23, 2025
@guilara guilara force-pushed the PRs-GradExtrinsicCurvature branch from f64f1f7 to 453ac78 Compare May 23, 2025 15:19
@guilara guilara changed the title Add covariant derivative of extrinsic curvature Add spatial covariant derivative of extrinsic curvature May 23, 2025
@guilara guilara force-pushed the PRs-GradExtrinsicCurvature branch 4 times, most recently from a2e04be to b4d102b Compare May 24, 2025 13:36
@guilara guilara marked this pull request as ready for review May 24, 2025 13:41
@guilara guilara force-pushed the PRs-GradExtrinsicCurvature branch from b4d102b to 53f5e61 Compare May 24, 2025 15:21
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple small suggestions. Please squash immediately :)

@guilara guilara force-pushed the PRs-GradExtrinsicCurvature branch from 53f5e61 to 404b261 Compare May 29, 2025 10:53
@guilara guilara requested a review from nilsdeppe May 29, 2025 13:59
@nilsdeppe nilsdeppe merged commit 7a701d3 into sxs-collaboration:develop May 29, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants