Skip to content

Conversation

@wthrowe
Copy link
Member

@wthrowe wthrowe commented May 1, 2025

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a question :)

@wthrowe wthrowe force-pushed the variable_order_errors branch from 17f232f to ffc70c4 Compare June 10, 2025 21:36
@nilsdeppe nilsdeppe merged commit a132a12 into sxs-collaboration:develop Jun 12, 2025
23 of 24 checks passed
@nilsdeppe
Copy link
Member

CI failure was in Poisson ProductOfSinusoids, so unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants