Only interpolate for horizon finds from certain blocks #6611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d36f635 to
9008704
Compare
nilsdeppe
requested changes
May 1, 2025
| "outflow-type boundary condition, you must use that."); | ||
| } | ||
| using domain::BoundaryConditions::is_periodic; | ||
| if (boundary_condition_ != nullptr and is_periodic(boundary_condition_)) { |
Member
There was a problem hiding this comment.
Only the important domains ;) :D
src/ParallelAlgorithms/ApparentHorizonFinder/InterpolationTarget.cpp
Outdated
Show resolved
Hide resolved
src/ParallelAlgorithms/ApparentHorizonFinder/InterpolationTarget.hpp
Outdated
Show resolved
Hide resolved
src/ParallelAlgorithms/ApparentHorizonFinder/InterpolationTarget.hpp
Outdated
Show resolved
Hide resolved
src/ParallelAlgorithms/Interpolation/Actions/InitializeInterpolator.hpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@nilsdeppe Pushed fixups |
nilsdeppe
requested changes
May 3, 2025
| std::make_index_sequence< | ||
| std::tuple_size_v<std::decay_t<decltype(all_horizon_options)>>>{}); | ||
| expand_pack(append_to_result( | ||
| tmpl::at<option_tags<Metavariables>, tmpl::size_t<Is + 1>>::name(), |
Member
There was a problem hiding this comment.
you can use at_c and then don't need the tmpl::size_t
These are currently taken as options from the input file. Eventually we could have this be more automatic, e.g. the domain creators know which blocks could potentially hold a horizon, but that would be a future optimization
86d81d2 to
3d620a2
Compare
nilsdeppe
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
These are currently taken as options from the input file. Eventually
we could have this be more automatic, e.g. the domain creators know
which blocks could potentially hold a horizon, but that would be
a future optimization.
This is the first step in a lot of backend work to combine the horizon finders and get rid of the interpolator group component.
I've tested this on a single BH while interpolating only some blocks and all blocks. And also tried on a BBH
Upgrade instructions
Each entry under the
ApparentHorizons:block of the input file gets a new optionBlocksForInterpolation:. This could either be a list of block groups orAllto indicate all blocks in the doman.Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments