Skip to content

Conversation

@wthrowe
Copy link
Member

@wthrowe wthrowe commented Apr 23, 2025

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

wthrowe added 3 commits April 23, 2025 12:48
Convenient for checking `variant == expected_value` in tests.
Test utilities just assume fixed-order for the moment.
Good thing to check, but already done by -Wold-style-cast with fewer
false positives.
@kidder kidder merged commit 834381e into sxs-collaboration:develop Apr 28, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants