Skip to content

Conversation

@pajkosmi
Copy link
Contributor

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@pajkosmi pajkosmi force-pushed the template_ghgrmhd_on_neutrino_transport_stub branch 2 times, most recently from 289dd2a to 4de4ecf Compare April 24, 2025 17:54
@pajkosmi pajkosmi requested a review from nilsdeppe April 24, 2025 20:38
@pajkosmi pajkosmi marked this pull request as ready for review April 24, 2025 20:38
@pajkosmi
Copy link
Contributor Author

@nilsdeppe this can be reviewed at your leisure. I am just waiting on the comparison runs on mbot to finish. I should know the results by tomorrow.

@pajkosmi
Copy link
Contributor Author

The TOV central density evolutions for the early portion of the evolution match between the GhValenciaDivClean and GhValenciaDivClean<NeutrinoStubSystem> cases.

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does this need to be squashed or do the individual commits compile?

@pajkosmi pajkosmi force-pushed the template_ghgrmhd_on_neutrino_transport_stub branch from 4de4ecf to d378ce2 Compare May 1, 2025 18:21
@pajkosmi
Copy link
Contributor Author

pajkosmi commented May 1, 2025

Rebased and squashed

@nilsdeppe nilsdeppe merged commit adfb3c9 into sxs-collaboration:develop May 2, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants