Skip to content

Conversation

@pajkosmi
Copy link
Contributor

@pajkosmi pajkosmi commented Apr 3, 2025

Proposed changes

Remove template parameters from struct TimeDerivativeTermsImpl.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@pajkosmi pajkosmi marked this pull request as ready for review April 3, 2025 18:49
@pajkosmi pajkosmi requested a review from nilsdeppe April 3, 2025 18:49
@pajkosmi pajkosmi force-pushed the make_time_deriv_terms_more_local branch from 3e72c55 to 8c02f1e Compare April 23, 2025 23:22
@pajkosmi
Copy link
Contributor Author

@nilsdeppe I've refactored this PR. Ready to review

@nilsdeppe nilsdeppe merged commit e4f3207 into sxs-collaboration:develop Apr 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants