fix(editor): added option for consuming application to add samples in… #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a58c5a to
9d2e2a3
Compare
…app code base, Readme pending
9d2e2a3 to
07a13b1
Compare
sabberworm
reviewed
May 10, 2025
Collaborator
sabberworm
left a comment
There was a problem hiding this comment.
Thanks for tackling this. Looks cool!
As always 😆, I do have some suggestions to make this feature more generic.
SgiobairOg
approved these changes
May 16, 2025
marcofra
approved these changes
May 19, 2025
sabberworm
requested changes
May 19, 2025
src/main/content/jcr_root/apps/jcr-hopper/script-builder/scripts/.content.xml
Show resolved
Hide resolved
src/main/content/jcr_root/apps/jcr-hopper/script-builder/scripts/.content.xml
Outdated
Show resolved
Hide resolved
src/main/java/com/swisscom/aem/tools/jcrhopper/osgi/SampleContributor.java
Show resolved
Hide resolved
sabberworm
reviewed
May 19, 2025
Collaborator
Author
|
Hi @sabberworm , The issue that occurred with rebase is resolved now. Could you please review? |
sabberworm
approved these changes
May 22, 2025
Collaborator
sabberworm
left a comment
There was a problem hiding this comment.
LGTM. I do have some reservations about the README becoming too complex (and too specific) and added some suggestions to simplify. But we can also tackle this some other time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.