Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/survey-core/src/question_slider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,24 @@ export class QuestionSliderModel extends Question implements ISliderLabelItemOwn
private get isLabelsShowValueText(): boolean {
return !!this.customLabels.find(l => l.showValue);
}

public itemValuePropertyChanged(item: ItemValue, name: string, oldValue: any, newValue: any): void {
if (this.autoGenerate === true) {
const index = this.generatedLabels.indexOf(item);
this.autoGenerate = false;
this.setPropertyValue("customLabels", this.calcGeneratedLabels());
item = this.customLabels[index];
}
if (name === "text") {
if (Number.isFinite(+newValue)) {
item.value = +newValue;
} else {
item.text = newValue;
}
}
super.itemValuePropertyChanged(item, name, oldValue, newValue);

}
}

function getCorrectMinMax(min: any, max: any, isMax: boolean, step: number): any {
Expand Down
18 changes: 18 additions & 0 deletions packages/survey-core/tests/question_slider_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -959,4 +959,22 @@ QUnit.test("Preview", (assert) => {
const event: any = { target: { value: 50 } };
slider.handleOnChange(event, 0);
assert.deepEqual(slider.renderedValue, [0], "the value doesn't changed");
});

QUnit.test("itemValuePropertyChanged for labels inplace editing in Creator https://github.com/surveyjs/survey-creator/issues/7205", (assert) => {
let q1 = new QuestionSliderModel("q1");
q1.labelCount = 1;
const label1 = q1.generatedLabels[0];
label1.text = "min";
assert.equal(q1.autoGenerate, false);
assert.equal(q1.customLabels[0].text, "min");
assert.equal(q1.customLabels[0].value, 0);

let q2 = new QuestionSliderModel("q2");
q2.labelCount = 1;
const label2 = q2.generatedLabels[0];
label2.text = "5";
assert.equal(q2.autoGenerate, false);
assert.equal(q2.customLabels[0].text, "5");
assert.equal(q2.customLabels[0].value, 5);
});