This repository was archived by the owner on Mar 5, 2021. It is now read-only.
Add Typescript editor #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
OK we're getting there 👍 There are a few changes to make as @bilou84 said: #2 (comment). You don't need to close the pull request or delete the branch to do it! Just amend your commit and force push. Let me know if you need guidance :) |
Contributor
Author
|
Okey it's good ? |
Contributor
|
You didn't have to do a new commit. You could amend the first one and force push it. |
Contributor
Author
|
@bilou84 Okey in git ext. I click on "Ecraser le commit" ? |
Contributor
|
Yes this one |
Contributor
|
This needs some review and additional work. We'll get back to it once the dust has settled on the core itself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.