fix(archdocs): guard against start_line > end_line in source snippet extraction#90
Merged
greynewell merged 1 commit intomainfrom Apr 9, 2026
Merged
fix(archdocs): guard against start_line > end_line in source snippet extraction#90greynewell merged 1 commit intomainfrom
greynewell merged 1 commit intomainfrom
Conversation
…extraction When API data has start_line > end_line, lines[sl-1:el] panics with "slice bounds out of range" because sl-1 > el creates a reversed range. Add sl <= el to the bounds check so malformed line numbers are skipped rather than crashing the build. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA boundary validation fix in the source-code extraction logic: the slice range check now verifies that the start line doesn't exceed the end line ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pssg/build/build.go, when extracting source code snippets from entity pages, the code doeslines[sl-1:el]after checkingsl <= len(lines) && el <= len(lines)sl > el(start_line > end_line in the API response), this creates a reversed slice range and panics withslice bounds out of rangesl <= elto the bounds guard so malformed line numbers skip the extraction instead of crashing thesupermodel docsbuildTest plan
go build ./...passessupermodel docson a repo with normal source data still shows source snippets correctly🤖 Generated with Claude Code
Summary by CodeRabbit